Moti Asayag has posted comments on this change. Change subject: core: make network DAO extend the generic DAO ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAODbFacadeImpl.java Line 22: private static ParameterizedRowMapper<network> parameterizedRowMapper; I think that static block should be written at the top of the class and that's how the latest 'refactor/organize' patches are committed. however, I'd prefer keeping de-facto convention of defining the row mapper as a private static class, rather anonymous class. By that, mappers can be reused by many DAOs if required (e.g. createGuidMapper, createBooleanMapper...) -- To view, visit http://gerrit.ovirt.org/2205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I981650bbb761cc956b3e218c754961e35e297d47 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
