Yair Zaslavsky has posted comments on this change.
Change subject: core: Prestarted Vm (4)
......................................................................
Patch Set 2: (5 inline comments)
....................................................
File backend/manager/dbscripts/vm_pools_sp.sql
Line 17:
vm_pool_type,parameters, prestarted_vms, vds_group_id)
remove tabs
Line 146: assigned_vm_count,
remove tabs
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java
Line 61: if
(DbFacade.getInstance().getDiskImageDAO().getAllStatelessVmImageMapsForVm(vm.getId()).size()
> 0) {
Same mocking comment as before
Line 62: log.infoFormat("Deleting snapshots for stateless vm {0}",
vm.getId());
Please dont use this {0} , and use String.format instead.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java
Line 65: entity.setPrestartedVms(rs.getInt("prestarted_vms"));
Can't you see you're duplicating code here?:)
Why not extract to a static inner mapper? :)
--
To view, visit http://gerrit.ovirt.org/2266
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90f108e282adc1951edaf84be22057b15be483ec
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
