Moti Asayag has posted comments on this change. Change subject: core : Adding GetImagesByStorageDomainAndTemplateQuery query ......................................................................
Patch Set 1: Looks good to me, approved (2 inline comments) Please split the patch next time for 2 patches: first patch for the refactor, second patch for the new query which uses the first one. Remove trailing white spaces and consider replace in commit message "all images that are belongs to template" to all images that are belongs to any template" so it is more clear. .................................................... File backend/manager/dbscripts/images_sp.sql Line 235: please remove TWS Line 240: IF v_template_id IS NULL then please replace tab with spaces and so the IF could be indented. -- To view, visit http://gerrit.ovirt.org/2304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic588f452df34f8401b5556ca4d4cc606ce1c91b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
