Alona Kaplan has posted comments on this change. Change subject: core: removed final from VM._diskList ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java Line 1125: private java.util.ArrayList<DiskImage> _diskList = new java.util.ArrayList<DiskImage>(); I think you also have to add a setter. Because the next time somebody will edit and save this file the formatter will add the final automatically. After you add the setter check that there is no problem editing a vm (because the _diskList field is no longer read-only the backend doesn't ignore it when editing a vm, if the frontend passes the wrong value it can cause a problem the previously wasn't seen). -- To view, visit http://gerrit.ovirt.org/2340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e09999fabf947db4ce2f3c0fb49431b820fcaad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Danny Rankevich <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
