Omer Frenkel has posted comments on this change.

Change subject: engine: Add consume quota permission to add VM
......................................................................


Patch Set 13: Looks good to me, but someone else must approve

(2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java
Line 80:     @Override
no need to override if you don't change implementation

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
Line 205:     public List<PermissionSubject> getPermissionCheckSubjects() {
no need to override if you don't change implementation

--
To view, visit http://gerrit.ovirt.org/2111
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bbc3f969b8a04ad3e4ed229320cb55b63ea3fdb
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to