Muli Salem has posted comments on this change. Change subject: core: Fixes in SnapshotsManager ......................................................................
Patch Set 3: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java Line 139: vm.setInterfaces(DbFacade.getInstance().getVmNetworkInterfaceDAO().getAllForVm(vm.getId())); For test purposes, it will be better if you extract to a private method that calls: DbFacade.getInstance().getVmNetworkInterfaceDAO(). Line 145: VmTemplate t = DbFacade.getInstance().getVmTemplateDAO().get(vm.getvmt_guid()); Same comment. -- To view, visit http://gerrit.ovirt.org/2312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6819f6e6f496e9ef01a234d3075a1a302eb7ba2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
