Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup PermissionDAO
......................................................................
Patch Set 8: (2 inline comments)
answered review.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java
Line 19: @SuppressWarnings("synthetic-access")
Making the class static would not resolve the synthetic access issue.
Removing the private modifier would, but I don't think that's a good idea.
What will also work is holding a singleton *instance* of the mapper instead of
creating a new one, but that's a change I don't want to make as part of a
"cleanup" patch.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAOHibernateImpl.java
Line 165: @SuppressWarnings("unused")
`-)
--
To view, visit http://gerrit.ovirt.org/2214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33cb0b89d68608d1ad44edca755a08a6a8379053
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
