Moti Asayag has posted comments on this change. Change subject: core: vm_device upgrade script patch ......................................................................
Patch Set 1: (6 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_01_0530_vm_device_upgrade_data.sql Line 4: Generally, it looks that too many logic is put in this function which may harden the debug if issues around it. If there are no performance concerns bout this function (e.g. being executed from VdsUpdateRuntimeInfo), I'd think of extracting the logic. Line 22: -- set device memmory according to number of monitors s/memmory/memory Line 106: when 6 then -- DNC DNC should be * cdrom * network * disk Line 110: when 7 then -- NCD NCC should be * network * disk * cdrom .................................................... Commit Message Line 9: This is the first patch in a patch serias for the Stable Device Addresses feature. s/serias/series - appears several time. you can run spell-checker when editing the commit message by: ": set spell" Line 13: See full detail on oVirt wiki site (search for 'stable device addresses') you can put here a direct link to the wiki page: http://www.ovirt.org/wiki/Features/Design/StableDeviceAddresses -- To view, visit http://gerrit.ovirt.org/2398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4685889e4651a531ba15182aa516221b2f2ef730 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
