Michael Kublin has posted comments on this change.
Change subject: core: Update VM devices on DB when hash changes
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 810: } else {
These can not work , the value is the same
Line 873: }
You should retrieve all devices here, an not one by one. Because of actually
you are retrieving all devices at handleRemovedDevices
--
To view, visit http://gerrit.ovirt.org/2410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia963db83d88cb11c57be197c40d64f1e1b3c88c9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
