Yaniv Kaul has posted comments on this change. Change subject: sdk: support server url with no protocol ......................................................................
Patch Set 1: (1 inline comment) .................................................... File src/ovirtsdk/web/connection.py Line 80: url = "http://" + url I'd use 'https'. Why have a non-secure option if no protocol has been specified? Unless specifically asked for, the default should be secure. -- To view, visit http://gerrit.ovirt.org/2487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabb182fe981dd9f0e07c096accd13d3856f13643 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
