Gal Hammer has posted comments on this change. Change subject: Add more detailed memory statistics function to guest agent. ......................................................................
Patch Set 1: (3 inline comments) Thanks for the patch. Seems okay to me. I just wonder if the new information should be included in the "heart beat" message. .................................................... File ovirt-guest-agent/GuestAgentLinux2.py Line 11: import os, rpm, socket, subprocess, string, threading, logging, re Why not use "split" like in the getAvailableRAM function? .................................................... File ovirt-guest-agent/OVirtAgentLogic.py Line 40: def getMemoryStats(self): Rather than adding new message and method, why not to add this information to the "heart beat" message? .................................................... File ovirt-guest-agent/ovirt-guest-agent.conf Line 11: report_memory_stats = 5 Need to add this field to the Windows' ovirt-guest-agent.ini file as well. -- To view, visit http://gerrit.ovirt.org/2272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic93b8717f99f033caf2b5dc2404a55f903bf4b0a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
