Moti Asayag has posted comments on this change.
Change subject: core: added Entities utility class to build map of entities by
name
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java
Line 11: if (entityList != null) {
perhaps worth to add check also for: !entityList.siEmpty() before creating new
instance so null value and empty list will behave the same.
That's means that the returned map in both cases is unmodifiable and worth be
mentioned in javadoc.
Line 24: Map<String, E> map = new HashMap<String, E>();
same as above.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Nameble.java
Line 3: public interface Nameble {
Could you fix name type to Nameable ?
See http://dictionary.reference.com/browse/nameable
Also quick javadoc for this interface is more than welcome.
--
To view, visit http://gerrit.ovirt.org/2473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I752671576c04904f517101a5fbf412c86477dead
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
