Moti Asayag has posted comments on this change.
Change subject: core: Add vmNetwork and bridgeless fields to the
VdsNewtorkInterface and network entities
......................................................................
Patch Set 7: (3 inline comments)
Consider adding the new properties to the fixtures.
....................................................
File backend/manager/dbscripts/upgrade/03_01_0600_add_bridgeless_columns.sql
Line 2: select fn_db_add_column('vds_interface', 'bridged', 'boolean NOT NULL
DEFAULT true');
please note current available sequence script number is 03_01_0570
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network.java
Line 317: }
the getters/setters tend to come prior to hash/equal
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAODbFacadeImpl.java
Line 21:
please consider following:
http://www.ovirt.org/wiki/Backend_Coding_Standards
--
To view, visit http://gerrit.ovirt.org/2472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4f93cb77617dd32d6330980b069dc0a1bec8277
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
