Moti Asayag has posted comments on this change.
Change subject: restapi: unit tests for VersionUtilsTest
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/utils/VersionUtilsTest.java
Line 24: private org.ovirt.engine.api.model.Version compatVersion(Integer
major,
the name mislead, since it returns org.ovirt.engine.api.model.Version copy, not
the copmat Version.
Line 35:
first, well done for adding the tests.
The org.ovirt.engine.core.compat.Version is part of the Compat project,
therefore the equal() and testToString() test should be moved to
ovirt-engine/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/VersionTest.java
And this test should be focused on org.ovirt.engine.api.model.Version, so
you're missing here the test for
public static boolean greaterOrEqual(org.ovirt.engine.api.model.Version a,
org.ovirt.engine.api.model.Version b) {...}
--
To view, visit http://gerrit.ovirt.org/2571
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6712e12a134933e6b70c72dd56780b7021b1a4d0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
