Roy Golan has posted comments on this change.
Change subject: engine-core: minor ImagesHandler cleanup
......................................................................
Patch Set 3: Looks good to me, approved
That a good idea for now to gather such null checking and
later we need to insert the "Checker Framework" into our maven lifecycle and
use Annotation instead of defensive code:
boolean doThat(@NotNull List<String> messages) {
// no need to check as long as we
// know messages values is expected at compile time,
// i.e not an api call or silimiar
messages.add("Malawach");
}
http://types.cs.washington.edu/checker-framework/
--
To view, visit http://gerrit.ovirt.org/2675
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb57f4e48745089a53c1231777459a8e01d1e3b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
