Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: Introducing AddVmAndCloneImageCommand ......................................................................
Patch Set 12: (7 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java Line 42: protected void copyDiskImage(Guid destVmId, 1. destVmId is not used 2. You don't have to actually pass vmId as parameter since you always use getVmId() anyway. Line 47: DiskImage newDiskImage = cloneDiskImage(getVmId(), Same thing here (about vm id passing) Line 49: Guid.NewGuid(), You don't have to pass Guid.NewGuid() as parameter, since you don't save it or use it later anyway, so it can just be used as is inside the method. Line 50: Guid.NewGuid(), Ditto.. Line 135: /** This should be regular comment, not javadoc Line 153: VdcReturnValueBase result = Backend.getInstance().runInternalAction( I think you should execute the command only if source image is not ILLEGAL Line 209: MoveOrCopyImageGroupParameters moveOrCopyImageGroupParams = (MoveOrCopyImageGroupParameters) param; If you cast it anyway, then the method signature should receive this type of parameter. -- To view, visit http://gerrit.ovirt.org/2656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ff02972a4bfaa5696ac07eab7f825468fc52dfe Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
