Allon Mureinik has posted comments on this change.
Change subject: engine-core: CpuFlagsManagerHandler cleanup
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
Looks good to me - see a couple of small inline comments.
Also, this class uses the following pattern kind a bit:
Set<String> someSet = new HashSet<String>(Arrays.asList(someString.split("[:"));
Perhaps it might be a good idea to introduce a splitToSet(String) method?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
Line 164: // if no flags at all create new list instead
of split
While you're at it, I think this HashSet can be declared as Set
Line 228: } else {
here too.
Line 389: ServerCpu result = null;
here too.
--
To view, visit http://gerrit.ovirt.org/2749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1168a002aef7f338c8d4458ec35f5a31a978add
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
