Michael Pasternak has posted comments on this change.
Change subject: DO NOT SUBMIT api: Adding support for clone vm from snapshot
......................................................................
Patch Set 26: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
Line 98: && !vm.getSnapshots().getSnapshots().isEmpty()) {
please write test for this use-case, you can use /clone/ test as a reference.
thanks.
Line 119: vm.getSnapshots(),
minor: you can reuse /String snapshotId/ L100 instead of sending
/vm.getSnapshots()/ and retrieving it again.
--
To view, visit http://gerrit.ovirt.org/2302
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8b8285cfe193a1d501c28af042021f4649bc299
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
