Moti Asayag has posted comments on this change. Change subject: engine-core: valueValidationFunction cleanup ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java Line 72: ValueValidationFunction charValidation = validCahracters; would you rather going an extra mile and treat the way those variables are being created ? The classes implementing the ValueValidationFunction has public modifier, no state of their own. .................................................... Commit Message Line 11: - ValueValidationFunction is transformed into an interface ith only the s/ith/with .................................................... File frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/SearchBackend.gwt.xml Line 25: <include name="searchbackend/valueValidationFunction.java" /> I guess this can be removed. -- To view, visit http://gerrit.ovirt.org/2816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ce6f930834a5ba8a207345e45d088f4b9fd0ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
