Allon Mureinik has posted comments on this change. Change subject: engine-core: QueriesCommandBase cleanup ......................................................................
Patch Set 1: (1 inline comment) Not a fan of this change. the query type is used in the (commented out) validatePermissions method, which is waiting for the frontend guys to complete their side so it can be uncommented and integrated. I don't see a benefit in removing it just in order to return it in a couple of weeks. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java Line 5 This suppresses the warning about explicitly declaring Serializable for an enum, which is implicitly Serializable. AFAIK, this is needed by the GWT frameworks the UI uses. -- To view, visit http://gerrit.ovirt.org/2439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f099b33c614f373b6b664456eed1d901628ea9c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
