Allon Mureinik has posted comments on this change. Change subject: engine-core: unit-test for SyntaxCheckerFactory ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (4 inline comments) +1, some minor inline comments .................................................... File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java Line 12: private static final String ADSyntaxChecker = "ADSyntaxChecker"; I suggest you move this cleanup to the relevant patch (http://gerrit.ovirt.org/2822) .................................................... File backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java Line 14: @Test java convention: please use lower case letters in the beginning of method names Line 22: @Test same here. Line 30: @Test and here. -- To view, visit http://gerrit.ovirt.org/2821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb8b044eadbd2c8264e067a1d56a200873849979 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
