Roy Golan has posted comments on this change.
Change subject: engine-core: BaseConditionFieldAutoCompleter cleanup
......................................................................
Patch Set 1: (4 inline comments)
nice refactoring. I'm thinking how to insert the Bean Validator in use instead
of these checks.
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
Line 160: Regex validChar = new Regex("^[^\\<\\>&^#!']*$");
move and cache the RegExp in Validationutils
Line 193: test = tempRefObject.argvalue;
test is not used
also retval is invaluble. this could be:
return TimeSpan.tryParse(value, new RefObject<TimeSpan>(new TimeSpan());
Line 207: test = tempRefObject.argvalue;
same as above
Line 221: test = tempRefObject.argvalue;
same as above
--
To view, visit http://gerrit.ovirt.org/2817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61dd8fa9bac3b5391e4f233dbaf0aa7fcb6dbaa2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
