Moti Asayag has posted comments on this change. Change subject: history: added dwh events to audit log (#772925) ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java Line 530: VDS_ALERT_FENCING_OPERATION_SKIPPED(9003), I meant the gap of the enum numeric values: 9701, 9700 and jump to 9704. In addition, the values could be written an ascending order (of the ordinal value) In addition, please keep the the enum values ordered by their ordinal -- To view, visit http://gerrit.ovirt.org/2631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dcddd24713dbbc41646c830cc1d16bde58c3ccf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
