Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: Implementation of Network Interfaces popups
......................................................................
userportal: Implementation of Network Interfaces popups
The implementation of the Network Interfaces popups for both
VMs and Templates.
The implementation of the widget(NetworkInterfacePopupWidget) is the
same for both.
The difference between the view for VM and for Template is that the
template one has no MAC address configuration. This is solved by hiding
this widgets from the screen, when the getMAC.getIsAvailable() returns
false on the VmInterfaceModel (and set this property in the
TemplateInterfaceListModel).
This patch also includes the following small fixes:
- UserPortalSearchableDetailModelProvider needs to implement the
SearchableDetailModelProvider, but it implemented the
DetailModelProvider (othervise the setSelectedItem will not be
called on it after the selection is changed in the table)
- to the TemplateInterfaceListModel.remove() added
model.setHashName("remove_network_interface_tmps"); which enables
the RemoveConfirmationPopupView to show the correct message
Change-Id: I27941700901974839175d43a2f4e282cf334613e
---
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateInterfaceListModel.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java
A
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/networkinterface/NetworkInterfacePopupPresenterWidget.java
A
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/networkinterface/NetworkInterfacePopupView.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/UserPortalSearchableDetailModelProvider.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/template/TemplateInterfaceListModelProvider.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/VmInterfaceListModelProvider.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/template/TemplateInterfacePopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmInterfacePopupView.java
11 files changed, 286 insertions(+), 172 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2795
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27941700901974839175d43a2f4e282cf334613e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
