Ofer Schreiber has posted comments on this change.
Change subject: packaging: enable ovirt installation on ports lower than 1024
......................................................................
Patch Set 1: Fails
(23 inline comments)
....................................................
File packaging/fedora/setup/engine-setup.py
Line 143: { 'description' : 'Handling httpd',
Shouldn't we do this before "Final steps"? (start JBoss and configure IPtables?)
Line 202:
w/s
Line 756: cmd = ["setsebool","-P","httpd_can_network_connect","1"]
consts?
full path to setsebool?
Line 765: handler.editParam("SSLCertificateFile",
"/etc/pki/ovirt-engine/certs/engine.cer")
any reason this is not CONST?
Line 773:
w/s
Line 779: There for we may need to ask the user whether to override this
configuration
spelling
Line 793: return True
please explain why we always return true
Line 794:
w/s
Line 800: redirectStr="ProxyPass /
ajp://localhost:%s/"%(basedefs.JBOSS_AJP_PORT)
You redirect everything, which is fine, but your comment says otherwise
Line 809: def _listenHttpPort():
meaningless function name
Line 1693:
w/s
Line 2127: configJbossAjpConnector(xmlObj)
should we always configure the AJP port? even if we don't use httpd?
does it matter? (security, etc?)
....................................................
File packaging/fedora/setup/engine_validators.py
Line 48: #TODO: add actual port check with socket open
but you already have this...
Line 72:
whitespace
Line 104: def validateOverrideHttpdCondAndChangePortsAccordingly(param,
options=[]):
Really?
Line 107: It actually changes the default HTTP/S ports in case the user
choose not to override the httpd configuration.
whitespace
Line 109: logging.info("validateOptionsAndChangePortsAccordingly %s as part
of %s"%(param, options))
this is not the function name
Line 118: else:
so if the user entered "bla" you'll stop httpd?
Line 123:
ws
....................................................
File packaging/fedora/setup/output_messages.py
Line 106: Do you wish to override current httpd configuration and restart the
service?"
What is RHEVM?
s/JBOSS/JBoss/
Line 166: INFO_VAL_PORT_OCCUPIED_BY_JBOSS="ERROR: TCP Port %s is used by jboss"
s/jboss/JBoss
Line 229: ERR_FAILED_TO_RESTART_JBOSS_SERVICE = "Failed restarting Jboss
service"
s/Jboss/JBoss
....................................................
File packaging/fedora/setup/ovirt_port80.py
Line 69:
multiple w/s
--
To view, visit http://gerrit.ovirt.org/2961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3307ed7aee556ebee6021a47c4b9c7e4583b42d3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Barak Azulay <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
