Mike Kolesnik has posted comments on this change. Change subject: core: Fix VmDAO.getForImage to return multiple VMs ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java Line 65: Map<Boolean, List<VM>> result = new HashMap<Boolean, List<VM>>(2); This map will grow when you add the second entry, it is better to initialize to 2 / load factor, which is 75% by default. This is approx. 3 :) -- To view, visit http://gerrit.ovirt.org/2933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7100a7aa15524d35f664b49248e5a37cbfb6a32c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
