Mike Kolesnik has posted comments on this change.
Change subject: core: Adding some logging to query
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java
Line 68: log.info(String.format("Image %1$s of Disk %2$s cannot
be found in database. This image will be returned as ILLEGAL from the query",
I would use log.infoFormat since it is the standard way.
Also, I think logging this at info level is too verbose, this sounds more like
a debug to me (and if someone wants to monitor this query specifically he can
lower it's log level)
--
To view, visit http://gerrit.ovirt.org/3103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4036f62a50aa6f7cf24850aa1ae0cf2dc0feed12
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
