Mike Kolesnik has posted comments on this change. Change subject: core: Changes to compensation context ......................................................................
Patch Set 4: (2 inline comments) Generally good just a couple small comments .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java Line 16: instance = new NoOpCompensationContext(); Why put in static block, you can just initialize the variable inline. Also, you can have the field as final, as it is not to be changed. Line 20: Why this empty line? -- To view, visit http://gerrit.ovirt.org/3179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a28c8144461cc84b414e64f4f27fb99d0aa9248 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
