Vojtech Szocs has posted comments on this change. Change subject: webadmin: I18N for TagModel.name (#786448) ......................................................................
Patch Set 1: Looks good to me, approved Indeed, this is a union of all (both ASCII and Unicode) word character ranges, plus additional ASCII characters (0-9, _ and -). Things would be much easier if JavaScript specification (ECMA) dealt with Unicode-aware character classes. Most browsers strictly adhere to the standard, which means '\w' (word character class) matches only ASCII characters, namely A-Z, a-z, 0-9, and _ only. -- To view, visit http://gerrit.ovirt.org/3146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5a722bfa34f38362aad7d93c25c3cd3dad574ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
