Allon Mureinik has uploaded a new change for review. Change subject: core: Fix NPE when remove storage domain (#783083) ......................................................................
core: Fix NPE when remove storage domain (#783083) https://bugzilla.redhat.com/783083 Bug #783083 describes how attempting to remove a non existant Storage Domain causes a NullPointerException. This patch contains a test to reproduce the bug without the UI, a fix for it, and a new error message to be issued when attempting such behavior. The error message is declared in multiple properties files, as per the guidelines in http://www.ovirt.org/wiki/Engine_Adding_Messages. Change-Id: I59fba5ba715fb02fb69c48cfc79f20b17830fced --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 76 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/21/3221/1 -- To view, visit http://gerrit.ovirt.org/3221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I59fba5ba715fb02fb69c48cfc79f20b17830fced Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
