Michael Kublin has posted comments on this change. Change subject: core: extract common plug/unplug canDo checks ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PlugUnplugCommons.java Line 5: import org.ovirt.engine.core.compat.Version; Cool, from now inheritance is wrong design. Due your logic all methods at the class which are common between all children, but has not shared state should be static? If these is utility please provide where it will be used at other place except the following class family -- To view, visit http://gerrit.ovirt.org/3202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f8a6749989f04c13195c7dddb69b93bc4a0d4f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
