Mike Kolesnik has posted comments on this change. Change subject: core: Migrated LoggedUtilsTest to Mockito ......................................................................
Patch Set 3: (1 inline comment) Basically +2 just one comment .................................................... File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/log/LoggedUtilsTest.java Line 248: verify(log, never()).traceFormat(any(String.class), any()); You could more simply verify that isLogLevelOn is called and then no more interactions :) This can work also, but then it is copy pasted a lot so it might make sense to extract (though not really that important).. -- To view, visit http://gerrit.ovirt.org/3244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If01b736151033288424ae6a4d68ea97f9667f880 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
