Jonathan Choate has posted comments on this change. Change subject: core: Refactor SchedulerUtilQuartz ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java Line 171: Object[] inputParams, It seems like there is a lot more duplication here that can be factored out. Additionally these methods are doing two things - creating a job and scheduling it. I would consider refactoring based on separating those two actions. -- To view, visit http://gerrit.ovirt.org/3247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica8f9591d38a0ee18e7e901cf05ea2deafb52182 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Jonathan Choate <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
