Moti Asayag has posted comments on this change. Change subject: core: Fix VmTemplate serializing (#808866) ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) there are already mappers for VmTemplate serialize/deserialize. .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java Line 58: mapper.getSerializationConfig().addMixInAnnotations(VmTemplate.class, JsonVmTemplateMixIn.class); bad copy & paste here: s/getSerializationConfig()/getDeserializationConfig() .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java Line 56: mapper.getSerializationConfig().addMixInAnnotations(VmTemplate.class, JsonVmTemplateMixIn.class); VmTemplate already appears before - seems this is not required. I think this patch should be abandoned and a new one to extend JsonVmTemplateMixIn.class should be added instead, if problem exists. -- To view, visit http://gerrit.ovirt.org/3297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a5632b9e2beb8244096deaa46c95c25b446b915 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
