Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: Setup Host Networks Feature
......................................................................
webadmin: Setup Host Networks Feature
This feature allows the editing of a Host Network Topology.
All topology changes are done on the dialog, and sent in one request to the
backend.
The implementation uses Models and Views to manipulate the Following Networking
Items:
* Network Interface Card (physical nic on the Host)
* Channel Bond (defined on the Host)
* Logical Network (network defined on the cluster level)
Models:
NetworkItemModel
|
+--LogicalNetworkModel
|
+--NetworkInterfaceModel
|
+--BondNetworkInterfaceModel
Views:
NetworkItemPanel
|
+--NetworkPanel
|
+--NicPanel
|
+--BondPanel
* Interactions between the Models are done using Network Operations.
* The Operations are defined as static enums, and operate on two operands.
* When the Operation is Unary, the second operand is null;
Following is a list of Operations, with the expected Operand Types:
+------------------+---------------------------+---------------------------+
| Operation | Operand 1 | Operand 2 |
+------------------+---------------------------+---------------------------+
| BREAK_BOND | BondNetworkInterfaceModel | null |
| DETACH_NETWORK | LogicalNetworkModel | null |
| ATTACH_NETWORK | LogicalNetworkModel | NetworkInterfaceModel |
| BOND_WITH | NetworkInterfaceModel | NetworkInterfaceModel |
| ADD_TO_BOND | NetworkInterfaceModel | BondNetworkInterfaceModel |
| REMOVE_FROM_BOND | NetworkInterfaceModel | null |
| NULL_OPERATION | null | null |
+------------------+---------------------------+---------------------------+
* The Operations can be activated through Drag & Drop, or through a context
menu.
* An Operation Factory is responsible for resolving a valid Operation for any
two given Operands.
* Result might be the NULL_OPERATION.
* The same is also responsible for calculating a Matrix of possible Operations
for a given Network topology
(to be used in context menus).
====================================================
Additional Changes (required by the implementation):
* UICommand: Add Executing with parameters.
* UICommand: Add IsVisible property.
* TabModelProvider: allow resolving the View according to a Model, in addition
to the last executed command.
* Fix a bug in the UiCommonEditorVisitor when there is already a Selected Item.
* Add a Status Widget tot the Popup View
* Mkae sure Popup contents are scrolled in case of overflow
Drag & Drop support:
====================================================
Using HTML5 DnD specification:
http://www.w3.org/TR/html5/dnd.html
HTML5 DnD is supported by standard complaint browsers (Chrome and Firefox, and
IE9).
IE8 does not support it (has it's own DnD mechanism) - IE8 users will have to
use the context menu.
Since this was implemented only in GWT 2.4, I copied the Event classes, and did
the event sinking in the DnDPanel.
IMPORTANT: when upgrading to 2.4, remove the classes in the
"com.google.gwt.event.dom.client" and "com.google.gwt.dom.client" packages,
as well as the DnDPanel.
Change-Id: I2b79c1e02f38c2e2078a5ad19dcc7a4d7f2232ea
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TabModelProvider.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundPopupView.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiCommandButtonDefinition.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiMenuBarButtonDefinition.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/AbstractDialogPanel.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/BaseCommandTarget.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ICommandTarget.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/BondNetworkInterfaceModel.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkCommand.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkInterfaceModel.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkItemModel.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationCommandTarget.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/OperationCadidateEventArgs.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/RowEditModel.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/dom/client/DataTransfer.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragDropEventBase.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragEndEvent.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragEndHandler.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragEnterClickHandler.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragEnterEvent.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragEnterHandler.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragEvent.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragHandler.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragLeaveEvent.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragLeaveHandler.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragOverEvent.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragOverHandler.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragStartEvent.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragStartHandler.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DropEvent.java
A
frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DropHandler.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostSetupNetworksPopupPresenterWidget.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.ui.xml
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/InterfaceEditor.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/InterfaceEditor.ui.xml
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ConnectorPanel.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/editor/AnimatedVerticalPanel.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/StatusLabel.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/form/DnDPanel.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ActionColumn.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_left.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_left_middle.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_bottom.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_middle.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_one.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_top.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/bond.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/item_draggable.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/mgmt_net.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/network_monitor.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/network_vm.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/nic_down.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/nic_edit.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/nic_icon.png
A
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/nic_up.png
91 files changed, 4,556 insertions(+), 63 deletions(-)
Approvals:
Danny Rankevich: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b79c1e02f38c2e2078a5ad19dcc7a4d7f2232ea
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Danny Rankevich <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
