Yair Zaslavsky has posted comments on this change.

Change subject: core: quota support for multiple storage images - DO NOT SUBMIT
......................................................................


Patch Set 13: (2 inline comments)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonAddVmTemplateParametersMixIn.java
Line 21:     public abstract HashMap<Guid, DiskImage> 
getDiskInfoDestinationMap();
As an attempt to get rid of MixIns, now that common's pom.xml includes Jackson 
- please annotate getDiskInfoDestinationMap at VmTemplate with @JsonIgnore.

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVmManagementParametersBaseMixIn.java
Line 19:     public abstract HashMap<Guid, DiskImage> 
getDiskInfoDestinationMap();
See other comment about Mixin and annotating an entity directly with 
@JsonIgnore.

--
To view, visit http://gerrit.ovirt.org/3090
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e4b7e28fb9dd3069e86bd8fdf41255398fd1e58
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to