Omer Frenkel has posted comments on this change.
Change subject: new feature: Vm Payload
......................................................................
Patch Set 3: (5 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/03_01_0990_payload_size_config.sql
Line 1: select fn_db_add_config_value('PayloadSize','8192','general');
if we want to expose this to the user, it should be added to the configuration
util xml
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 487: VmDeviceType.DISK,
shouldn't be CDROM/FLOPPY?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 843: if (canDoAction && getParameters().getVmPayload() != null) {
what if payload in params is null but is in db and user asked for cd?
also maybe extract this code to some shared location and re-use?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 114: dao.removeAll(devs);
i think you can use here:
dao.removeAll(Collections.singletonList(oldPayload.getId()));
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1663:
do we still need it in vm if this is implemented as a vm device?
--
To view, visit http://gerrit.ovirt.org/3243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2820acfa8ec0f736e5fe0ce192e84df0915f12
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
