Allon Mureinik has posted comments on this change. Change subject: core: Adding action_version_map for command ......................................................................
Patch Set 2: Looks good to me, but someone else must approve Looks good. Not sure if if I wouldn't prefer the script to be reentrant (i.e., use select where not exists to verify this row isn't already there) for safety sake, but it seems this is no longer the convention (e.g., 03_01_0680_add_setupnetwork_to_action_version_map.sql). -- To view, visit http://gerrit.ovirt.org/3373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee072258572f3ddacd2cef7005881325fea477b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
