Moti Asayag has posted comments on this change. Change subject: core : Clean up of RemoveVmTemplateFromImportExportCommand ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java Line 67: retVal = !(images == null); please change to: images != null Line 116: storageIds.add(getParameters().getStorageDomainId()); I'd take an extra precautions with this, since we're sharing same instance among the images. -- To view, visit http://gerrit.ovirt.org/3375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4afddb2ed21b5affab884fad50c0d55d62249db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
