Maor Lipchuk has posted comments on this change. Change subject: core: No empty quotas in storage global default ......................................................................
Patch Set 5: (2 inline comments) .................................................... File backend/manager/dbscripts/quota_sp.sql Line 28: RETURN QUERY SELECT * Please remove space here Line 41: WHERE (v_allow_empty OR storage_size_gb IS NOT NULL); Why did you use inner query, and not simply add conditions to the where of the existing one? Same comment for the similar patch for vdsGroup -- To view, visit http://gerrit.ovirt.org/3310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d3d992115b8ba88072fff6e14a54fbc43bcb9e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
