Vojtech Szocs has posted comments on this change. Change subject: webadmin: manage cluster networks dialog ......................................................................
Patch Set 7: Submitted new patch that sets up ClusterNetworkManageModel's "vmNetwork" and "required" fields according to "clusterNetwork". This patch renames ClusterNetworkManageModel's "optional" field to "required", to reflect the same field of "network" business entity. One question: "required" check-box column is currently editable, yet when I change its value, ClusterNetworkManageModel's isRequired() is not called at all within UiCommon code. Should "required" check-box column be really editable? I'd say it should be non-editable, since ClusterNetworkListModel.OnManage() performs only following actions: AttachNetworkToVdsGroup, DetachNetworkToVdsGroup, UpdateDisplayToVdsGroup. -- To view, visit http://gerrit.ovirt.org/3209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I617a73105dcadd6733b4a854ebdece47b066d367 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Danny Rankevich <danny....@gmail.com> Gerrit-Reviewer: Danny Rankevich <danny....@gmail.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
