Moti Asayag has posted comments on this change.
Change subject: core: Check permission on Storage Domain when adding disk
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskToVmCommand.java
Line 206: VdcObjectType.Disk,
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1301: if (storagePool == null) {
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 37: List<PermissionSubject> permsList = null;
if CommandBase.getJobMessageProperties isn't overridden then this method is
used to get the entities names.
Line 295: }
don't think there is a need to observe the type of the operation.
however, I'll ask for permission on the disk.
Do you think there is a reason for 2 separate action groups for copy/move disk ?
--
To view, visit http://gerrit.ovirt.org/3399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cc0d89e2a2a94ab103c9f373d038961231f13c3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
