Gustavo Frederico Temple Pedrosa has posted comments on this change.
Change subject: webadmin: Show only compatible OSes
......................................................................
Patch Set 2:
(4 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java
Line 123: for (int osId : getOsIds()) {
Line 124: String architecture =
getValueByVersion(idToUnameLookup.get(osId), "cpuArchitecture", null);
Line 125: ArchitectureType archType =
ArchitectureType.valueOf(architecture);
Line 126:
Line 127: if (architecture != null) {
Done
Line 128: osArchitectures.put(osId, archType);
Line 129: }
Line 130: }
Line 131: return osArchitectures;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 3121: new OsQueryParameters(OsRepositoryVerb.GetMaxOsRam,
osId, version),
Line 3122: asyncQuery);
Line 3123: }
Line 3124:
Line 3125: public static ArchitectureType getArchitectureTypeByOsId(int
osId) {
Done
Line 3126: return osArchitectures.get(osId);
Line 3127: }
Line 3128:
Line 3129: public static ArrayList<Map.Entry<String, EntityModel>>
getBondingOptionList(RefObject<Map.Entry<String, EntityModel>> defaultItem)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 108: public abstract void provisioning_SelectedItemChanged();
Line 109:
Line 110: public abstract void updateMinAllocatedMemory();
Line 111:
Line 112: public abstract void postOsItemChanged();
Done
Line 113:
Line 114: protected void postInitTemplate() {
Line 115:
Line 116: }
Line 980: vmOsValues =
AsyncDataProvider.getOsIds(cluster.getArchitectureType());
Line 981: getModel().getOSType().setItems(vmOsValues);
Line 982: }
Line 983:
Line 984: postOsItemChanged();
Done
Line 985: }
Line 986:
Line 987: protected void updateSelectedCdImage(VmBase vmBase) {
Line 988: getModel().getCdImage().setSelectedItem(vmBase.getIsoPath());
--
To view, visit http://gerrit.ovirt.org/17972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19f5a2fa8ca6a54e75f4ff64c4b6189db13ed25d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
