Yair Zaslavsky has posted comments on this change.
Change subject: core: Fence via second power management not work...
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Minor comment,
I do not want to block the patch on this.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
Line 517: if (returnValue != null &&
returnValue.getReturnValue() != null) {
Line 518: FenceStatusReturnValue value =
(FenceStatusReturnValue) returnValue.getReturnValue();
Line 519: if
(value.getStatus().equalsIgnoreCase("unknown")) {
Line 520: // No need to retry , agent definitions are
corrupted
Line 521: log.warnFormat("Host {0} {1} PM Agent
definitions are corrupted, Waiting for Host to {2) aborted.", vdsName,
order.name(), actionType.name());
just warn? wouldn't you want to use error here? Just a suggestion, not too
critical.
Line 522: break;
Line 523: }
Line 524: else {
Line 525: if
(FENCE_CMD.equalsIgnoreCase(value.getStatus())) {
--
To view, visit http://gerrit.ovirt.org/18481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c05e96e2c8d5f690addda61e0dd577c423ff07
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
