Michael Pasternak has posted comments on this change.
Change subject: cli: Update power management agent type via CLI failed
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File src/ovirtcli/command/command.py
Line 132: if len(param_data) == 2:
Line 133: spplited_param_data =
param_data[0].split('.')
Line 134: for param_period in
spplited_param_data:
Line 135: if spplited_param_data[-1] ==
param_period:
Line 136: if param_period == 'type':
param_period = 'type_'
to avoid future bugs on same issue, i'd add generic method that checks if
param_period in python preserved words and append the "_" suffix when it's true
Line 137: if
hasattr(obj_params_set_cand, param_period):
Line 138: if
getattr(obj_params_set_cand, param_period) != None:
Line 139: getattr(obj,
props[i]).append(obj_params_set_cand)
Line 140: obj_params_set_cand =
params_set_cand.factory()
--
To view, visit http://gerrit.ovirt.org/19104
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6211c636ee35a6b46723c747a67c77ea2176e808
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
