Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Query for gluster volume rebalance status
......................................................................
Patch Set 15:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java
Line 42: new
GlusterVolumeVDSParameters(getUpServerId(clusterId), volume.getName()));
Line 43:
Line 44: // Set the volume re-balance start time
Line 45: GlusterVolumeTaskStatusEntity entity =
(GlusterVolumeTaskStatusEntity)returnValue.getReturnValue();
Line 46: List<Step> stepsList =
getDbFacade().getStepDao().getStepsByExternalId(volume.getAsyncTask().getStepId());
Yes, even I was thinking of the same as this would be required in case there is
no async task started, it would give a NPE.
Will do the same.
Line 47: if (stepsList != null && !stepsList.isEmpty()) {
Line 48: entity.setStartTime(stepsList.get(0).getStartTime());
Line 49: }
Line 50:
--
To view, visit http://gerrit.ovirt.org/18352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3704f750fafcf3546c5237a4dde67b5f85a691e4
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
