Arik Hadas has uploaded a new change for review. Change subject: core: override hashCode method when override equals method ......................................................................
core: override hashCode method when override equals method Two classes which were recently added override the 'equals' method but not the 'hashCode' method. Findbugs detected that such case might violate the invariant that equal objects mush have equal hashcodes. Thus, in this patch those classes are changed to override the 'hashCode' method as well. Change-Id: I34b5932eddb3a54391eeab4b203d8f68ca5fe546 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/19168/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java index 4837eb6..5401a73 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java @@ -61,6 +61,11 @@ public boolean equals(Object obj) { return ((Disk) obj).isWipeAfterDelete(); } + + @Override + public int hashCode() { + return 56; + } }); } return cachedPostZero; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java index 465e0ec..cc7bbde 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java @@ -46,6 +46,11 @@ public boolean equals(Object obj) { return ((Disk) obj).isWipeAfterDelete(); } + + @Override + public int hashCode() { + return 95; + } }); } return cachedPostZero; -- To view, visit http://gerrit.ovirt.org/19168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I34b5932eddb3a54391eeab4b203d8f68ca5fe546 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
