Mike Kolesnik has posted comments on this change.
Change subject: tools: Add validation to MAC Address range
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java
Line 30: String[] rangeParts = range.split("[-]", -1);
Line 31: if (rangeParts.length == 2) {
Line 32: String rangeStart = rangeParts[0].toLowerCase();
Line 33: String rangeEnd = rangeParts[1].toLowerCase();
Line 34: if (!validateRangePart(rangeStart) ||
!validateRangePart(rangeEnd)
Why not differentiate between the cases and let the user know which part is
invalid, or that the end MAC must be greater than the start MAC?
Line 35: || rangeStart.compareTo(rangeEnd) > 0) {
Line 36: return new ValidationResult(false, "The entered
range is invalid. "
Line 37: + StringUtils.join(rangeParts, '-')
Line 38: + " should be in a format of
AA:AA:AA:AA:AA:AA-BB:BB:BB:BB:BB:BB,...");
Line 33: String rangeEnd = rangeParts[1].toLowerCase();
Line 34: if (!validateRangePart(rangeStart) ||
!validateRangePart(rangeEnd)
Line 35: || rangeStart.compareTo(rangeEnd) > 0) {
Line 36: return new ValidationResult(false, "The entered
range is invalid. "
Line 37: + StringUtils.join(rangeParts, '-')
You can simply use range variable here?
Line 38: + " should be in a format of
AA:AA:AA:AA:AA:AA-BB:BB:BB:BB:BB:BB,...");
Line 39: }
Line 40: } else {
Line 41: return new ValidationResult(false, "The entered value
is in imporper format. " + value
--
To view, visit http://gerrit.ovirt.org/19261
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I821290d8d48ed164a5c653367d59774bd97bf67e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
