Ayal Baron has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ForceSelectSPMCommand.java
Line 50: return
failCanDoAction(VdcBllMessages.CANNOT_FORCE_SELECT_SPM_VDS_MARKED_AS_NEVER_SPM);
Line 51: }
Line 52:
Line 53: if (!validate(new
StoragePoolValidator(getStoragePoolForVds()).isUp())) {
Line 54: return false;
why are you not throwing a meaningful error? (e.g. spm can only be set when
datacenter is 'up')
Line 55: }
Line 56:
Line 57: if (isAsyncTasksRunningOnPool(getStoragePoolForVds().getId()))
{
Line 58: return
failCanDoAction(VdcBllMessages.CANNOT_FORCE_SELECT_SPM_STORAGE_POOL_HAS_RUNNING_TASKS);
--
To view, visit http://gerrit.ovirt.org/19123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f59f891d392fbc7c80cc21df3672d328221c007
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
