Sandro Bonazzola has posted comments on this change.
Change subject: packaging: spec: split ovirt-host-deploy-offline into own spec
......................................................................
Patch Set 1:
(3 comments)
....................................................
File Makefile.am
Line 63:
Line 64: TMPREPOS = tmp.repos
Line 65: srpm: dist
Line 66: rm -fr "$(TMPREPOS)"
Line 67: mkdir -p $(TMPREPOS)/{SPECS,RPMS,SRPMS,SOURCES}
here you can add also rpmbuild of the offline package
Line 68: $(RPMBUILD) --define="_topdir `pwd`/$(TMPREPOS)" -ts
"$(PACKAGE_TARNAME)-$(PACKAGE_VERSION).tar.gz"
Line 69: @echo
Line 70: @echo "srpm available at '$(TMPREPOS)'"
Line 71: @echo
Line 69: @echo
Line 70: @echo "srpm available at '$(TMPREPOS)'"
Line 71: @echo
Line 72:
Line 73: rpm: srpm
same here
Line 74: $(RPMBUILD) --define="_topdir `pwd`/$(TMPREPOS)" --rebuild
"$(TMPREPOS)"/SRPMS/*.src.rpm
Line 75: @echo
Line 76: @echo "rpm(s) available at '$(TMPREPOS)'"
Line 77: @echo
Line 106: OFFLINE_FILES = \
Line 107: ovirt-host-deploy-offline.spec \
Line 108: conf.d/50-offline-packager.conf \
Line 109: $(NULL)
Line 110: OFFLINE_TARBALL = $(PACKAGE_TARNAME)-offline-$(PACKAGE_VERSION).tar.gz
I suggest to add offline-tarball to dist target so make dist wiil create both
the archives and build rpms at rpm and srpm target.
Line 111: offline-tarball: $(OFFLINE_TARBALL)
Line 112: $(OFFLINE_TARBALL): $(OFFLINE_FILES)
Line 113: tar -czf $(PACKAGE_TARNAME)-offline-$(PACKAGE_VERSION).tar.gz \
Line 114: --transform "s#^#$$(echo $(OFFLINE_TARBALL) | sed
's/\.tar.*//')/#" \
--
To view, visit http://gerrit.ovirt.org/19151
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26513d02fd1c95a2a515781884a7283e77a5c2ff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
